You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "driseley (via GitHub)" <gi...@apache.org> on 2024/05/14 15:16:17 UTC
[PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
driseley opened a new pull request, #14145:
URL: https://github.com/apache/camel/pull/14145
# Description
Ensure that any hypens or underscores in parameters in REST templates are removed before being parsed into a regular expression
The code will remove (using a regular expression match) any hyphens or underscores in REST template parameter names. This is required as the parameter name are parsed into regular expression named groups which support only letters and numbers as group names.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
https://issues.apache.org/jira/browse/CAMEL-20763
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14145:
URL: https://github.com/apache/camel/pull/14145#issuecomment-2111724710
org.apache.camel.support.RestConsumerContextPathMatcherTest.testRestConsumerContextPathMatcherOrder | 0.028s | ERROR
-- | -- | --
org.apache.camel.support.RestConsumerContextPathMatcherTest.testRestConsumerContextPathMatcherWithWildcard | 0.002s | ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14145:
URL: https://github.com/apache/camel/pull/14145#issuecomment-2110507498
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #14145:
URL: https://github.com/apache/camel/pull/14145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
Posted by "driseley (via GitHub)" <gi...@apache.org>.
driseley commented on PR #14145:
URL: https://github.com/apache/camel/pull/14145#issuecomment-2110513955
If this is accepted could it also be backported to the 4.4.x LTS release? As this was introduced in 4.2.0 - it is not required on the 4.0.x LTS release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20763: camel-support Handle special characters in REST templates [camel]
Posted by "driseley (via GitHub)" <gi...@apache.org>.
driseley commented on PR #14145:
URL: https://github.com/apache/camel/pull/14145#issuecomment-2111845312
Apologies I thought I had run the tests, clearly I had not. That's fixed now and should pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org