You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/14 11:39:48 UTC
[GitHub] [incubator-shardingsphere] longjy opened a new pull request #3972:
Determine if there is an encryption requirement according to all SQL tables
longjy opened a new pull request #3972: Determine if there is an encryption requirement according to all SQL tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3972
Only modified here, but it is not clear whether only the first table was judged for other reasons before
see https://github.com/apache/incubator-shardingsphere/issues/3971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3972:
Determine if there is an encryption requirement according to all SQL tables
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-579615841
Closed because we change the default branch from dev to master.
Please re-summit pr to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3972:
Determine if there is an encryption requirement according to all SQL tables
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-574494561
@longjy Hi sir, thanks for your PR.
what you modified appears reasonable, however could you add one unit test to verify our conclusion? My suggestion is to new one unit test or add test for `EncryptStatementTest` or `EncryptPreparedStatementTest`. :-)
Look forward your reply, thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3972:
Determine if there is an encryption requirement according to all SQL tables
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #3972: Determine if there is an encryption requirement according to all SQL tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3972: Determine if there is an encryption requirement according to all SQL
tables
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3972: Determine if there is an encryption requirement according to all SQL tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-574494561
@longjy Hi sir, thanks for your PR.
what you modified appears reasonable, however could you add one unit test to verify our conclusion? My suggestion is to new one unit test or add test for `EncryptStatementTest` or `EncryptPreparedStatementTest`. :-)
Look forward to your reply, thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services