You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/01 09:56:35 UTC

[GitHub] [apisix-dashboard] anldrms opened a new issue #2301: FR - limit-count plugin form need to add allow_degradation section.

anldrms opened a new issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301


   # FR - limit-count plugin form need to add allow_degradation section.
   
   ## Apisix Dashboard Plugin Editor
   ![resim](https://user-images.githubusercontent.com/21142588/151945868-e9ee81db-0b3b-4ed4-a158-a80dd1882dee.png)
   
   On the limit-count editor there's something missing on form table. 
   
   ## Our problem
   
   allow_degradation default value has false. But if we want trying to change it to true there's no option to do that in form table. And if we'll switch to json table and can change it to manually , unfortunatelly  if there will be change on form table after this step it going to dissapear.
   
   ## Request
   
   There should be some options on form table be able to do change values which on plugin editors(limit-count , limit-conn etc.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] anldrms commented on issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
anldrms commented on issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301#issuecomment-1041418505


   Awesome , thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] anldrms commented on issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
anldrms commented on issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301#issuecomment-1041333720


   @oil-oil I'm looking forward to fix it as soon as you can possible. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301#issuecomment-1030758302


   cc @guoqqqi to have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] oil-oil commented on issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
oil-oil commented on issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301#issuecomment-1041253317


   Please assign it to me, I'll fix this .😃


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] oil-oil commented on issue #2301: FR - limit-count plugin form need to add allow_degradation section.

Posted by GitBox <gi...@apache.org>.
oil-oil commented on issue #2301:
URL: https://github.com/apache/apisix-dashboard/issues/2301#issuecomment-1041347924


   > @oil-oil I'm looking forward to fix it as soon as you can possible. Thanks.
   
   OK, It is almost finished, and the PR is expected tomorrow.🐵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org