You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Suresh Srinivas (Created) (JIRA)" <ji...@apache.org> on 2011/12/01 02:47:39 UTC
[jira] [Created] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
-----------------------------------------------------------------
Key: HDFS-2616
URL: https://issues.apache.org/jira/browse/HDFS-2616
Project: Hadoop HDFS
Issue Type: Sub-task
Components: data-node, name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: HA branch (HDFS-1623)
Attachments: HDFS-2616.txt
DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2616) Change
DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160710#comment-13160710 ]
Todd Lipcon commented on HDFS-2616:
-----------------------------------
+1, looks good.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Todd Lipcon (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reopened HDFS-2616:
-------------------------------
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, hdfs-2616-addendum.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2616:
------------------------------
Attachment: hdfs-2616-addendum.txt
Needed a slight addendum here for the mocking of DatanodeProtocol in TestBPOfferService. It was previously returning null which was treated as "no commands", but now that triggers an NPE in the tests. I'll commit this trivial fix in a few minutes.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, hdfs-2616-addendum.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
I was missing some thing. Thanks for the catch. I am yet to run some tests to see if this really works. The ObjectWritable magic scares me :-)
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-2616.
-------------------------------
Resolution: Fixed
Committed hdfs-2616-addendum.txt as r1209315.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, hdfs-2616-addendum.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2616) Change
DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160588#comment-13160588 ]
Todd Lipcon commented on HDFS-2616:
-----------------------------------
Still seems like HeartbeatResponseWritable isn't implementing Writable... am I missing something?
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
Updated patch. Tests were failing previously because transition to translator for DatanodeProtocol is not complete and HeartbeatResponse needs to be Writable.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-2616:
---------------------------------
Component/s: ha
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, hdfs-2616-addendum.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2616) Change
DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160561#comment-13160561 ]
Suresh Srinivas commented on HDFS-2616:
---------------------------------------
running tests on this patch.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
Empty constructors added to new writable. Thx Todd for catching it.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HDFS-2616.
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed it to HDFS-1623 branch.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
Small update.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2616) Change DatanodeProtocol#sendHeartbeat
to return HeartbeatResponse
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2616:
----------------------------------
Attachment: HDFS-2616.txt
patch with missing files attached!
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2616) Change
DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160566#comment-13160566 ]
Todd Lipcon commented on HDFS-2616:
-----------------------------------
Doesn't HeartbeatResponseWritable need to implement Writable? Otherwise looks good.
> Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse
> -----------------------------------------------------------------
>
> Key: HDFS-2616
> URL: https://issues.apache.org/jira/browse/HDFS-2616
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2616.txt
>
>
> DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira