[PATCH] Better contribulyzation of comments

[Malcolm Rowe <ma...@farside.org.uk>]

I've seen the recent patches to unindent '(Tweaked by me)' and the like
in log messages so that they don't appear in the Contribulyzer, and so I
was going to add a comment to that effect to the crediting section of
HACKING, but then I figured that it might be smarter for the
Contribulyzer to just ignore them anyway.

What do people think of the following patch?

[[[
Make the Contribulyzer treat indented parenthetical asides as asides
rather than names to generate a contribution summary for.

* tools/dev/contribulyze.py
  (parenthetical_aside_re): Allow (ignored) leading whitespace.
  (graze): In continuation lines for fields, ensure that lines that
    contain whitespace followed by an open parenthesis are not consider
    a named continuation for the field.
]]]

Note that I also removed the '+' quantifier from the '(\S.*)+' part of
the in_field_re regex, as I couldn't see that it would ever do anything
other than enforce a single match.

Regards,
Malcolm

Re: [PATCH] Better contribulyzation of comments

[Malcolm Rowe <ma...@farside.org.uk>]

On Fri, Apr 27, 2007 at 08:43:37AM -0700, Daniel Rall wrote:
> > Make the Contribulyzer treat indented parenthetical asides as asides
> > rather than names to generate a contribution summary for.
> > 
> 
> +1, looks good.

r24826, thanks.

Regards,
Malcolm

Re: [PATCH] Better contribulyzation of comments

[Daniel Rall <dl...@collab.net>]

On Fri, 27 Apr 2007, Malcolm Rowe wrote:

> I've seen the recent patches to unindent '(Tweaked by me)' and the like
> in log messages so that they don't appear in the Contribulyzer, and so I
> was going to add a comment to that effect to the crediting section of
> HACKING, but then I figured that it might be smarter for the
> Contribulyzer to just ignore them anyway.
> 
> What do people think of the following patch?
>
> [[[
> Make the Contribulyzer treat indented parenthetical asides as asides
> rather than names to generate a contribution summary for.
> 
> * tools/dev/contribulyze.py
>   (parenthetical_aside_re): Allow (ignored) leading whitespace.
>   (graze): In continuation lines for fields, ensure that lines that
>     contain whitespace followed by an open parenthesis are not consider
>     a named continuation for the field.
> ]]]
> 
> Note that I also removed the '+' quantifier from the '(\S.*)+' part of
> the in_field_re regex, as I couldn't see that it would ever do anything
> other than enforce a single match.

+1, looks good.