You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/09/02 09:35:16 UTC
[GitHub] zeppelin pull request #1398: [MINOR] Doc fix for spark interpreter
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1398
[MINOR] Doc fix for spark interpreter
### What is this PR for?
Several changes on doc of spark interpreter.
* %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
* Add SparkSession for 2.0
* Also add comments inline with other changes to explain the reason.
### What type of PR is it?
[Documentation]
### Todos
* [ ] - Task
### What is the Jira issue?
* No jira created.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin spark_doc_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1398
----
commit 40d4b11e29130fd8256af5c7848a1c7e7013c793
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-02T09:30:43Z
[MINOR] Doc fix for spark interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
Sorry @AhyoungRyu I didn't notice you PR is based on my branch and thought you will merge to master directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
@zjffdu Thank you for updating Spark interpreter docs. Looks great I think \U0001f44d
While I look through current Spark documentation page to review this PR, I found some typos, grammar errors and removed useless markdown escaping. So I fixed them based on your branch. If you don't mind, could you check [https://github.com/zjffdu/zeppelin/pull/1](https://github.com/zjffdu/zeppelin/pull/1) out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1398: [MINOR] Doc fix for spark interpreter
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1398
[MINOR] Doc fix for spark interpreter
### What is this PR for?
Several changes on doc of spark interpreter.
* %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
* Add SparkSession for 2.0
* Also add comments inline with other changes to explain the reason.
### What type of PR is it?
[Documentation]
### Todos
* [ ] - Task
### What is the Jira issue?
* No jira created.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin spark_doc_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1398
----
commit 40d4b11e29130fd8256af5c7848a1c7e7013c793
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-02T09:30:43Z
[MINOR] Doc fix for spark interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
@zjffdu It's okay :) LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
\cc @Leemoonsoo @AhyoungRyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
Merging into master if there are no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1398: [MINOR] Doc fix for spark interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1398: [MINOR] Doc fix for spark interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1398
@zjffdu Did you close this PR on purpose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1398: [MINOR] Doc fix for spark interpreter
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---