[GitHub] [spark] HeartSaVioR edited a comment on issue #27997: [SPARK-31101][BUILD][2.4] Upgrade Janino to 3.0.16

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #27997: [SPARK-31101][BUILD][2.4] Upgrade Janino to 3.0.16
URL: https://github.com/apache/spark/pull/27997#issuecomment-605721131
 
 
   It seems odd - I've just played with it a bit more, and added my observation to PR description. Quoting here again:
   
   > Note that there seems to be the case where another UT affects this UT to not fail - adding this to SQLQuerySuite won't fail this UT, but adding this to DateFunctionsSuite will fail this UT, and if you run this UT solely in SQLQuerySuite via `build/sbt "sql/testOnly *.SQLQuerySuite -- -z SPARK-31115"` then it fails.
   
   I don't think I should investigate to make it fail consistently - if that's the goal I would just add the UT to the code. The thing is that there's a case the query fails, and this PR fixes it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org