You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/10/14 03:04:44 UTC

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1008: add the workflow of check(spotbugs and license) and modify the files that failed to check

dailidong commented on issue #1008: add the workflow of check(spotbugs and license) and modify the files that failed to check
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1008#issuecomment-541489642
 
 
   thanks for contribution！
   
   but I notice this pr changed 241 files, no one could review so many changes one time.
   
   suggestion:
    one feature one pr may be better!
   
    if have big feature, please split it  to many small features!
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services