You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/05 18:14:02 UTC

[jira] [Commented] (TEZ-3849) PipelinedSorter silently drops records

    [ https://issues.apache.org/jira/browse/TEZ-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193360#comment-16193360 ] 

ASF GitHub Bot commented on TEZ-3849:
-------------------------------------

GitHub user jacobtolar opened a pull request:

    https://github.com/apache/tez/pull/21

    [TEZ-3849] PipelinedSorter silently drops records

    @jteagles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacobtolar/tez TEZ-3849

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tez/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit d32b47cf07b57b5afb9e6c51e9d812e989b58934
Author: Jacob Tolar <jt...@yahoo-inc.com>
Date:   2017-10-05T18:11:14Z

    [TEZ-3849] PipelinedSorter silently drops records

----


> PipelinedSorter silently drops records
> --------------------------------------
>
>                 Key: TEZ-3849
>                 URL: https://issues.apache.org/jira/browse/TEZ-3849
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jacob Tolar
>
> This bug was introduced in https://github.com/apache/tez/commit/a47e8fcbea5eeab5a7cf812271d329524cc02dba?diff=split 
> when combiner != null, the change in this commit passes kvIter with next() having already been called. This ends up (silently) dropping the first record in the partition. 
> Will submit PR and attach patch. [~jeagles], not sure if this is the way you want to fix or not but it does fix my tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)