[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #8313: Spark 3.4: Add write options to override the compression properties of the table

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #8313:
URL: https://github.com/apache/iceberg/pull/8313#discussion_r1294807775


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -63,4 +63,9 @@ private SparkSQLProperties() {}
   // Controls the WAP branch used for write-audit-publish workflow.
   // When set, new snapshots will be committed to this branch.
   public static final String WAP_BRANCH = "spark.wap.branch";
+
+  // Controls write compress options
+  public static final String COMPRESSION_CODEC = "spark.sql.iceberg.write.compression-codec";

Review Comment:
   We rarely use extra `write` and `read` namespaces in SQL properties, the only exception is preserving grouping as it was not clear otherwise. What about dropping `write` from all names?
   
   ```
   spark.sql.iceberg.compression-codec
   spark.sql.iceberg.compression-level
   spark.sql.iceberg.compression-strategy
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org