[jira] [Commented] (HBASE-14115) Fix resource leak in HMasterCommandLine

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631191#comment-14631191 ] 

Hadoop QA commented on HBASE-14115:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12745786/HBASE-14115.patch
  against master branch at commit 834f87b23de533783ba5f5b858327a6164f17f55.
  ATTACHMENT ID: 12745786

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14815//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14815//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14815//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14815//console

This message is automatically generated.

> Fix resource leak in HMasterCommandLine
> ---------------------------------------
>
>                 Key: HBASE-14115
>                 URL: https://issues.apache.org/jira/browse/HBASE-14115
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yuhao Bi
>            Assignee: Yuhao Bi
>         Attachments: HBASE-14115.patch
>
>
> In HMasterCommandLine#stopMaster(), admin is not closed.
> {code:title=HMasterCommandLine.java|borderStyle=solid}
> try (Connection connection = ConnectionFactory.createConnection(conf)) {
>       try (Admin admin = connection.getAdmin()) {
>         connection.getAdmin().shutdown();
>       } catch (Throwable t) {
>         LOG.error("Failed to stop master", t);
>         return 1;
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)