You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2023/01/02 15:54:07 UTC
[GitHub] [mynewt-newt] m-gorecki opened a new pull request, #497: Allow to download external repos without project.yml file
m-gorecki opened a new pull request, #497:
URL: https://github.com/apache/mynewt-newt/pull/497
This allows to download external repos like SDK packages, which do not contain project.yml files. Now we do not have to keep all of the SDKs in apache-mynewt-core repository. This also allows to use "@<repo-name>" syntax in the pkg.include_dirs and pkg.src_dirs fields to add source/include files from specified folders from external repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] michal-narajowski commented on a diff in pull request #497: Allow to download external repos without project.yml file
Posted by "michal-narajowski (via GitHub)" <gi...@apache.org>.
michal-narajowski commented on code in PR #497:
URL: https://github.com/apache/mynewt-newt/pull/497#discussion_r1087547963
##########
newt/repo/repo.go:
##########
@@ -194,6 +194,18 @@ func (r *Repo) patchesFilePath() string {
"/.patches/"
}
+// Checks for repository.yml file presence in specified repo folder.
+// If there is no such file, the repo in specified folder is external.
+func (r *Repo) IsExternal(dir string) bool {
+ path := dir + "/repository.yml"
+ _, err := os.Stat(path)
+ if os.IsNotExist(err) {
+ return true
+ } else {
+ return false
+ }
Review Comment:
```suggestion
return os.IsNotExist(err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] andrzej-kaczmarek merged pull request #497: Allow to download external repos without project.yml file
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek merged PR #497:
URL: https://github.com/apache/mynewt-newt/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org