[GitHub] [hudi] hddong commented on a change in pull request #1724: [HUDI-696] Add unit test for CommitsCommand

[GitBox <gi...@apache.org>]

hddong commented on a change in pull request #1724:
URL: https://github.com/apache/hudi/pull/1724#discussion_r439790402



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java
##########
@@ -214,15 +224,18 @@ public String showArchivedCommits(
     }
   }
 
-  @CliCommand(value = "commits refresh", help = "Refresh the commits")
-  public String refreshCommits() throws IOException {
+  @CliCommand(value = {"commits refresh", "refresh"}, help = "Refresh the commits")
+  public String refreshCommits() {
     HoodieCLI.refreshTableMetadata();
     return "Metadata for table " + HoodieCLI.getTableMetaClient().getTableConfig().getTableName() + " refreshed.";
   }
 
   @CliCommand(value = "commit rollback", help = "Rollback a commit")
   public String rollbackCommit(@CliOption(key = {"commit"}, help = "Commit to rollback") final String instantTime,
-      @CliOption(key = {"sparkProperties"}, help = "Spark Properties File Path") final String sparkPropertiesPath)
+      @CliOption(key = {"sparkProperties"}, help = "Spark Properties File Path") final String sparkPropertiesPath,
+      @CliOption(key = "sparkMaster", unspecifiedDefaultValue = "", help = "Spark Master") String master,
+      @CliOption(key = "sparkMemory", unspecifiedDefaultValue = "4G",

Review comment:
       > would the sparkMaster and sparkMemory put into sparkProperties? and if so, what's the priority?
   
   Usually put the parameters that are less changeable in `sparkProperties`, master and memory usually specified every time when run.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org