You are viewing a plain text version of this content. The canonical link for it is here.

Posted to bugs@httpd.apache.org by bu...@apache.org on 2009/08/27 20:24:43 UTC

DO NOT REPLY [Bug 39722] If DocumentRoot directive in config file has a non existent drive letter httpd crashes.

https://issues.apache.org/bugzilla/show_bug.cgi?id=39722



--- Comment #5 from Boya Sun <bo...@case.edu> 2009-08-27 11:24:42 PDT ---
Hi All,

According to this bugfix, the return value of ap_server_root_relative should be
checked to make sure that the directory exists.  So I think that a good
programming practice should be to always check its return value. And in fact,
the return value check IS preformed at 90% or the time when the function is
invoked in the entire project. 

However, there is a place in server/scoreboard.c, function open_scoreboard(),
where the return value check is missing.  Maybe this is because that a constant
value "ap_scoreboard_fname = DEFAULT_SCOREBOARD" is passed as the second
parameter of the function.  But I think it is safe to perform a check anyway.

The patch attached is against revision 806655.

Boya

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org