You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2006/10/24 07:35:16 UTC
[jira] Created: (HADOOP-629) none of the rpc servers check the
protcol name for validity
none of the rpc servers check the protcol name for validity
------------------------------------------------------------
Key: HADOOP-629
URL: http://issues.apache.org/jira/browse/HADOOP-629
Project: Hadoop
Issue Type: Bug
Components: ipc
Affects Versions: 0.7.2
Reporter: Owen O'Malley
Assigned To: Wendy Chien
Fix For: 0.8.0
All of the Hadoop RPC servers either ignore the protocol name or do:
if (protocol.equals(Prot1.class.getName()) {
return Prot1.versionId;
} else {
return Prot2.versionId;
}
A much better structure would be:
if (Prot1.class.getName().equals(protocol)) {
return Prot1.versionId;
} else if (Prot2.class.getName().equals(protocol)) {
return Prot2.versionId;
} else {
throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=all ]
Doug Cutting updated HADOOP-629:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
I just committed this. Thanks, Owen!
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: protocol-name.patch
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=all ]
Owen O'Malley updated HADOOP-629:
---------------------------------
Status: Patch Available (was: Open)
Fix Version/s: 0.10.0
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: protocol-name.patch
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=all ]
Owen O'Malley reassigned HADOOP-629:
------------------------------------
Assignee: Owen O'Malley (was: Wendy Chien)
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Owen O'Malley
> Attachments: protocol-name.patch
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=all ]
Owen O'Malley updated HADOOP-629:
---------------------------------
Attachment: protocol-name.patch
This patch fixes the name node, job tracker, and task tracker to reject rpc connections for the wrong protocols.
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Wendy Chien
> Attachments: protocol-name.patch
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=all ]
Owen O'Malley updated HADOOP-629:
---------------------------------
Fix Version/s: 0.9.0
(was: 0.8.0)
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Wendy Chien
> Fix For: 0.9.0
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-629) none of the rpc servers check the
protcol name for validity
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-629?page=comments#action_12455477 ]
Hadoop QA commented on HADOOP-629:
----------------------------------
+1, http://issues.apache.org/jira/secure/attachment/12346387/protocol-name.patch applied and successfully tested against trunk revision r481432
> none of the rpc servers check the protcol name for validity
> -----------------------------------------------------------
>
> Key: HADOOP-629
> URL: http://issues.apache.org/jira/browse/HADOOP-629
> Project: Hadoop
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.7.2
> Reporter: Owen O'Malley
> Assigned To: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: protocol-name.patch
>
>
> All of the Hadoop RPC servers either ignore the protocol name or do:
> if (protocol.equals(Prot1.class.getName()) {
> return Prot1.versionId;
> } else {
> return Prot2.versionId;
> }
> A much better structure would be:
> if (Prot1.class.getName().equals(protocol)) {
> return Prot1.versionId;
> } else if (Prot2.class.getName().equals(protocol)) {
> return Prot2.versionId;
> } else {
> throw new VersionMismatchException("Expected protocol Prot1 or Prot2 and received: " + protocol);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira