You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by hr...@apache.org on 2019/08/16 02:30:48 UTC

[pulsar-client-node] branch master updated: Fix compilation warning

This is an automated email from the ASF dual-hosted git repository.

hrsakai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git


The following commit(s) were added to refs/heads/master by this push:
     new e47d92d  Fix compilation warning
     new 5132c8e  Merge pull request #44 from massakam/fix-compilation-warn
e47d92d is described below

commit e47d92da39fd70e9834bb2587ff0f5fc5f405af8
Author: Masahiro Sakamoto <ma...@yahoo-corp.jp>
AuthorDate: Thu Aug 15 17:16:16 2019 +0900

    Fix compilation warning
---
 src/MessageId.cc   | 14 ++++++--------
 src/ReaderConfig.h |  4 ++--
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/MessageId.cc b/src/MessageId.cc
index ee6952c..96c1d5f 100644
--- a/src/MessageId.cc
+++ b/src/MessageId.cc
@@ -27,14 +27,12 @@ Napi::Object MessageId::Init(Napi::Env env, Napi::Object exports) {
   Napi::HandleScope scope(env);
 
   Napi::Function func = DefineClass(env, "MessageId",
-                                    {
-                                        StaticMethod("earliest", &MessageId::Earliest, napi_static),
-                                        StaticMethod("latest", &MessageId::Latest, napi_static),
-                                        StaticMethod("finalize", &MessageId::Finalize, napi_static),
-                                        InstanceMethod("serialize", &MessageId::Serialize),
-                                        StaticMethod("deserialize", &MessageId::Deserialize, napi_static),
-                                        InstanceMethod("toString", &MessageId::ToString)
-                                    });
+                                    {StaticMethod("earliest", &MessageId::Earliest, napi_static),
+                                     StaticMethod("latest", &MessageId::Latest, napi_static),
+                                     StaticMethod("finalize", &MessageId::Finalize, napi_static),
+                                     InstanceMethod("serialize", &MessageId::Serialize),
+                                     StaticMethod("deserialize", &MessageId::Deserialize, napi_static),
+                                     InstanceMethod("toString", &MessageId::ToString)});
 
   constructor = Napi::Persistent(func);
   constructor.SuppressDestruct();
diff --git a/src/ReaderConfig.h b/src/ReaderConfig.h
index 1983459..69fc634 100644
--- a/src/ReaderConfig.h
+++ b/src/ReaderConfig.h
@@ -34,9 +34,9 @@ class ReaderConfig {
   std::string GetTopic();
 
  private:
-  pulsar_reader_configuration_t *cReaderConfig;
-  pulsar_message_id_t *cStartMessageId;
   std::string topic;
+  pulsar_message_id_t *cStartMessageId;
+  pulsar_reader_configuration_t *cReaderConfig;
 };
 
 #endif