[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26240: [SPARK-29530][SQL][2.4] Make SQLConf in SQL parse process thread safe

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #26240: [SPARK-29530][SQL][2.4] Make SQLConf in SQL parse process thread safe
URL: https://github.com/apache/spark/pull/26240#discussion_r338855107
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
 ##########
 @@ -125,13 +125,13 @@ abstract class AbstractSqlParser extends ParserInterface with Logging {
 /**
  * Concrete SQL parser for Catalyst-only SQL statements.
  */
-class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser {
+class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser(conf) {
   val astBuilder = new AstBuilder(conf)
 }
 
 /** For test-only. */
-object CatalystSqlParser extends AbstractSqlParser {
-  val astBuilder = new AstBuilder(new SQLConf())
+object CatalystSqlParser extends AbstractSqlParser(SQLConf.get) {
+  val astBuilder = new AstBuilder(SQLConf.get)
 
 Review comment:
   > @AngersZhuuuu . We should not change this line because we don't have SPARK-27117 in `branch-2.4.`
   > 
   > Could you confirm this, @cloud-fan ?
   
   Seems he made this change with the same reason as me. I think it's ok. Am I right? @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org