You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/03/14 17:11:55 UTC
[PR] [fix](clucene) Fix GCC -Werror=overloaded-virtual in FieldForMerge [doris-thirdparty]
airborne12 opened a new pull request, #385:
URL: https://github.com/apache/doris-thirdparty/pull/385
## Summary
- Add `using` declarations in `FieldForMerge` to bring base class `Field`'s non-const virtual methods (`stringValue`, `readerValue`, `tokenStreamValue`) into scope
- This prevents GCC `-Werror=overloaded-virtual` errors when `Field.h` and `_FieldsReader.h` are included through different include chains in the same translation unit
- Verified locally with GCC 15.1.0 + Doris BE Release build
## Context
Apache Doris PR #59847 fails on Performance pipeline (GCC) because:
1. `CLucene/document/Field.h` declares `virtual tokenStreamValue()` (non-const)
2. `FieldForMerge` in `_FieldsReader.h` declares `tokenStreamValue() const` which hides the base class method
3. GCC with `-Wall -Werror` treats this as an error (`-Werror=overloaded-virtual`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](clucene) Fix GCC -Werror=overloaded-virtual in FieldForMerge [doris-thirdparty]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #385:
URL: https://github.com/apache/doris-thirdparty/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org