You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/05/17 17:15:57 UTC
[PR] feat(table): gate v2-only metadata fields on v1 reads [iceberg-go]
laskoviymishka opened a new pull request, #1088:
URL: https://github.com/apache/iceberg-go/pull/1088
Closes #1087. Stacked on top of #1069 — the diff will include #1069's helper introduction until that lands, after which a rebase makes this PR a clean delta.
#1069 introduced `rejectV3OnlyFields` for v3-only fields appearing in pre-v3 metadata. The same gate logic applies symmetrically to `last-sequence-number`, which is v2+ on the shared `commonMetadata` struct and is silently accepted on v1 reads today. This PR pulls the helper out to be version-agnostic — `rejectFieldsBeyondVersion(currentVersion, fields ...)` where each field carries the version it was introduced in — and wires `last-sequence-number` into the v1 read path. v2 reads pick up the same generalization for `next-row-id` / `encryption-keys` without behavior change.
Note this is contingent on the discussion in #1086. If we end up loosening the v3-only gate toward silent-ignore for forward-compat reasons, this PR is moot and should be revisited along with #1069's strictness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): gate v2-only metadata fields on v1 reads [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka merged PR #1088:
URL: https://github.com/apache/iceberg-go/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): gate v2-only metadata fields on v1 reads [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on PR #1088:
URL: https://github.com/apache/iceberg-go/pull/1088#issuecomment-4472118006
I replied back in #1086, lmk what you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): gate v2-only metadata fields on v1 reads [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on PR #1088:
URL: https://github.com/apache/iceberg-go/pull/1088#issuecomment-4471893660
@tanmayrauth PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org