[GitHub] spark pull request #22331: [SPARK-25331][SS] Make FileStreamSink ignore part...

[HeartSaVioR <gi...@git.apache.org>]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22331#discussion_r219399313
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StagingFileCommitProtocol.scala ---
    @@ -0,0 +1,141 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming
    +
    +import org.apache.hadoop.fs.{FileAlreadyExistsException, FileContext, Path}
    +import org.apache.hadoop.mapreduce.{JobContext, TaskAttemptContext}
    +
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.internal.io.FileCommitProtocol
    +import org.apache.spark.internal.io.FileCommitProtocol.TaskCommitMessage
    +
    +class StagingFileCommitProtocol(jobId: String, path: String)
    +  extends FileCommitProtocol with Serializable with Logging
    +  with ManifestCommitProtocol {
    +  private var stagingDir: Option[Path] = None
    --- End diff --
    
    Looks like you're using Option but always call `.get` without any checking. In `setupTask` it is fine since assignment is placed in there, but in `newTaskTempFile` we may be better to guard with `require` which achieves fail-fast and let `.get` always succeed later.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org