You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/05/08 11:01:25 UTC

[jira] [Commented] (WICKET-5093) The event listener in Wicket.Ajax.ajax() should not return the value of attrs.ad (allowDefault)

    [ https://issues.apache.org/jira/browse/WICKET-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651728#comment-13651728 ] 

Sven Meier commented on WICKET-5093:
------------------------------------

IMHO this change should be reverted and the issue be revisited in Wicket 7.x
                
> The event listener in Wicket.Ajax.ajax() should not return the value of attrs.ad (allowDefault)
> -----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5093
>                 URL: https://issues.apache.org/jira/browse/WICKET-5093
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.6.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 6.7.0
>
>
> Currently the event listeners registered in Wicket.Ajax.ajax() return the value of attrs.ad as a result.
> This is wrong because this way the event propagation is effected.
> event.preventDefault != event.stopPropagation
> If the propagation has to be stopped then a before handler can do "Wicket.Event.stop(attrs.event)" where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira