You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 00:45:35 UTC
[GitHub] [arrow] andygrove opened a new pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
andygrove opened a new pull request #7219:
URL: https://github.com/apache/arrow/pull/7219
With these changes, I can now see this output:
```
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: IoError("Reading types other than record batches not yet supported")
Error: IoError("Reading types other than record batches not yet supported")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: ParseError("invalid or unsupported type name: \"largebinary\" in Object({\"name\": String(\"largebinary\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
Error: IoError("Reading types other than record batches not yet supported")
Error: IoError("Reading types other than record batches not yet supported")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
Error: ParseError("invalid or unsupported type name: \"largebinary\" in Object({\"name\": String(\"largebinary\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: ParseError("invalid or unsupported type name: \"null\" in Object({\"name\": String(\"null\")})")
Error: JsonError("data type Date32(Day) not supported")
```
and
```
################# FAILURES #################
FAILED TEST: primitive Java producing, Rust consuming
FAILED TEST: primitive_zerolength Java producing, Rust consuming
FAILED TEST: null Java producing, Rust consuming
FAILED TEST: null_trivial Java producing, Rust consuming
FAILED TEST: datetime Java producing, Rust consuming
FAILED TEST: null Rust producing, Java consuming
FAILED TEST: null_trivial Rust producing, Java consuming
FAILED TEST: datetime Rust producing, Java consuming
FAILED TEST: primitive_large_offsets Rust producing, Rust consuming
FAILED TEST: null Rust producing, Rust consuming
FAILED TEST: null_trivial Rust producing, Rust consuming
FAILED TEST: datetime Rust producing, Rust consuming
12 failures
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #7219:
URL: https://github.com/apache/arrow/pull/7219#discussion_r426968094
##########
File path: rust/integration-testing/src/bin/arrow-json-integration-test.rs
##########
@@ -68,24 +69,19 @@ fn main() {
.value_of("json")
.expect("must provide path to json file");
let mode = matches.value_of("mode").unwrap();
- let verbose = matches.value_of("verbose").is_some();
+ let verbose = true; //matches.value_of("verbose").is_some();
Review comment:
I couldn't find a way to specify this when invoking archery, so hard-coded it for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7219:
URL: https://github.com/apache/arrow/pull/7219#issuecomment-630509610
https://issues.apache.org/jira/browse/ARROW-8854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on a change in pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on a change in pull request #7219:
URL: https://github.com/apache/arrow/pull/7219#discussion_r426969679
##########
File path: rust/integration-testing/src/bin/arrow-json-integration-test.rs
##########
@@ -68,24 +69,19 @@ fn main() {
.value_of("json")
.expect("must provide path to json file");
let mode = matches.value_of("mode").unwrap();
- let verbose = matches.value_of("verbose").is_some();
+ let verbose = true; //matches.value_of("verbose").is_some();
Review comment:
`archery --quiet`, RustTester should receive a `quiet: Bool` via [kwargs](https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/runner.py#L335) somehwere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #7219:
URL: https://github.com/apache/arrow/pull/7219#discussion_r427282251
##########
File path: rust/integration-testing/src/bin/arrow-json-integration-test.rs
##########
@@ -68,24 +69,19 @@ fn main() {
.value_of("json")
.expect("must provide path to json file");
let mode = matches.value_of("mode").unwrap();
- let verbose = matches.value_of("verbose").is_some();
+ let verbose = true; //matches.value_of("verbose").is_some();
Review comment:
Filed https://issues.apache.org/jira/browse/ARROW-8859 to resolve this as a follow on item
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7219:
URL: https://github.com/apache/arrow/pull/7219#issuecomment-630523481
@paddyhoran @nevi-me PTAL when you can
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7219: ARROW-8854: [Rust] [Integration Testing] Standardize error handling
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7219:
URL: https://github.com/apache/arrow/pull/7219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org