[GitHub] [lucene] gsmiller commented on pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

[GitBox <gi...@apache.org>]

gsmiller commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1005246240


   Nice find! With this kind of speedup just for avoiding the null check inside the counting loop, I wonder if it's worth generalizing beyond countAll? What about relaxing visibility of both `values` and `sparseValues` to `protected` and writing specialized counting logic for both `count` and `countAll` based on which is non-null? Essentially by-pass the `increment` abstraction provided by `IntTaxonomyFacets` for all cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org