Re: [PR] Fix potential overflow in binary search mid calculation [cloudberry]

["weinan003 (via GitHub)" <gi...@apache.org>]

weinan003 commented on code in PR #1028:
URL: https://github.com/apache/cloudberry/pull/1028#discussion_r2022542829


##########
gpcontrib/gpcloud/include/s3exception.h:
##########
@@ -127,7 +127,7 @@ class S3QueryAbort : public S3Exception {
 // AccessDenied, NoSuchBucket or other kinds of InvalidRequest
 class S3LogicError : public S3Exception {
    public:
-    S3LogicError(string code, string msg) : message(msg), awscode(code) {
+    S3LogicError(string code, string msg) : message(std::move(msg)), awscode(code) {

Review Comment:
   Is it to avoid double copying the params? Decorate the param with a const reference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org