You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 08:23:00 UTC

[GitHub] [apisix] dickens7 opened a new issue #4040: skywalking plugin attribute service_instance_name hard-coded

dickens7 opened a new issue #4040:
URL: https://github.com/apache/apisix/issues/4040


   ### Issue description
   
   Whether its attribute “service_instance_name” can be obtained automatically instead of hard-coded in the configuration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] dickens7 commented on issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
dickens7 commented on issue #4040:
URL: https://github.com/apache/apisix/issues/4040#issuecomment-820924599


   ok, assign it to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #4040:
URL: https://github.com/apache/apisix/issues/4040


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #4040:
URL: https://github.com/apache/apisix/issues/4040


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] dickens7 commented on issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
dickens7 commented on issue #4040:
URL: https://github.com/apache/apisix/issues/4040#issuecomment-820472127


   > @dickens7 Do you mean set `service_instance_name ` with the real APISIX instance name? 
   > 
   > For example, In k8s set `service_instance_name` with APISIX pod name.
   
   yes, it's necessary when there are many nodes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4040:
URL: https://github.com/apache/apisix/issues/4040#issuecomment-820889429


   @dickens7 
   PR is welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] gxthrj commented on issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #4040:
URL: https://github.com/apache/apisix/issues/4040#issuecomment-820453179


   @dickens7 Do you mean set `service_instance_name ` with the real APISIX instance name? 
   
   For example, In k8s set `service_instance_name` with APISIX pod name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #4040: skywalking plugin attribute service_instance_name hard-coded

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4040:
URL: https://github.com/apache/apisix/issues/4040#issuecomment-818615940


   @gxthrj 
   Could you help us to confirm it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org