You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/21 13:17:02 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #43033: [SPARK-45253][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
zhengruifeng opened a new pull request, #43033:
URL: https://github.com/apache/spark/pull/43033
### What changes were proposed in this pull request?
Correct the group of `ShiftLeft` and `ArraySize`
### Why are the changes needed?
`ShiftLeft` should be in the same group of `ShiftRight` and `ShiftRightUnsigned`;
`ArraySize` should be in the same group of `ArrayMax`, `ArrayCompact`, etc.
### Does this PR introduce _any_ user-facing change?
yes
the two functions will be shown in correct category in https://spark.apache.org/docs/latest/sql-ref-functions.html
### How was this patch tested?
manually check
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43033:
URL: https://github.com/apache/spark/pull/43033#issuecomment-1730764638
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43033:
URL: https://github.com/apache/spark/pull/43033#issuecomment-1730742391
also cc @cloud-fan @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43033:
URL: https://github.com/apache/spark/pull/43033#discussion_r1333848817
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -159,7 +159,7 @@ object Size {
4
""",
since = "3.3.0",
- group = "collection_funcs")
+ group = "array_funcs")
Review Comment:
in python, there are many functions in the incorrect groups
I will resolve it in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43033:
URL: https://github.com/apache/spark/pull/43033#discussion_r1333848369
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -1271,7 +1271,7 @@ case class Pow(left: Expression, right: Expression)
4
""",
since = "1.5.0",
- group = "math_funcs")
+ group = "bitwise_funcs")
Review Comment:
will do for python functions, in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
URL: https://github.com/apache/spark/pull/43033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43033:
URL: https://github.com/apache/spark/pull/43033#discussion_r1333848154
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -1271,7 +1271,7 @@ case class Pow(left: Expression, right: Expression)
4
""",
since = "1.5.0",
- group = "math_funcs")
+ group = "bitwise_funcs")
Review Comment:
Actually we'll need to update Scaladoc, and Python docs too. functions.scala and funcions.py and functions.R
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -159,7 +159,7 @@ object Size {
4
""",
since = "3.3.0",
- group = "collection_funcs")
+ group = "array_funcs")
Review Comment:
this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43033: [SPARK-45253][SQL][DOCS] Correct the group of `ShiftLeft` and `ArraySize`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43033:
URL: https://github.com/apache/spark/pull/43033#discussion_r1333849657
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -159,7 +159,7 @@ object Size {
4
""",
since = "3.3.0",
- group = "collection_funcs")
+ group = "array_funcs")
Review Comment:
🆗
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -159,7 +159,7 @@ object Size {
4
""",
since = "3.3.0",
- group = "collection_funcs")
+ group = "array_funcs")
Review Comment:
🆗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org