You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "dion gillard (JIRA)" <co...@jakarta.apache.org> on 2005/01/04 08:51:12 UTC

[jira] Created: (JELLY-188) tag library xml does not correctly parse body

tag library xml does not correctly parse body
---------------------------------------------

         Key: JELLY-188
         URL: http://issues.apache.org/jira/browse/JELLY-188
     Project: jelly
        Type: Bug
  Components: taglib.xml  
    Reporter: dion gillard


If I invoke some Jelly script within an xml tag this "body" will not be parsed
correctly. As far as I understand the code the sequence

            handler.startDocument();
            invokeBody( newOutput);
            handler.endDocument();

will always create an empty document since no tag will ever be reported and thus
all writes will be ignored.

The whole code in the body of the parseBody method in ParseTagSupport.java
should be replaced by

    protected Document parseBody(XMLOutput output) throws JellyTagException {
        return parseText(getBodyText(false));
    }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

Posted by "dion gillard (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57249 ]
     
dion gillard commented on JELLY-188:
------------------------------------

For the xmlunit taglibrary:

If I invoke some Jelly script within an xml tag this "body" will not be parsed
correctly. As far as I understand the code the sequence

            handler.startDocument();
            invokeBody( newOutput);
            handler.endDocument();

will always create an empty document since no tag will ever be reported and thus
all writes will be ignored.

The whole code in the body of the parseBody method in XMLUnitTagSupport.java
should be replaced by

    protected Document parseBody(XMLOutput output) throws JellyTagException {
        return parseText(getBodyText(false));
    }

> tag library xml does not correctly parse body
> ---------------------------------------------
>
>          Key: JELLY-188
>          URL: http://issues.apache.org/jira/browse/JELLY-188
>      Project: jelly
>         Type: Bug
>   Components: taglib.xml
>     Reporter: dion gillard

>
> If I invoke some Jelly script within an xml tag this "body" will not be parsed
> correctly. As far as I understand the code the sequence
>             handler.startDocument();
>             invokeBody( newOutput);
>             handler.endDocument();
> will always create an empty document since no tag will ever be reported and thus
> all writes will be ignored.
> The whole code in the body of the parseBody method in ParseTagSupport.java
> should be replaced by
>     protected Document parseBody(XMLOutput output) throws JellyTagException {
>         return parseText(getBodyText(false));
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

Posted by "Hans Gilde (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57807 ]
     
Hans Gilde commented on JELLY-188:
----------------------------------

I'm not clear on why the code that's there wouldn't work.

I'd say that the current solution is much faster because the SAX events are used directly (SAX Events->Document. The other solution uses SAX->Text->Parse->Document.

> tag library xml does not correctly parse body
> ---------------------------------------------
>
>          Key: JELLY-188
>          URL: http://issues.apache.org/jira/browse/JELLY-188
>      Project: jelly
>         Type: Bug
>   Components: taglib.xml
>     Reporter: dion gillard

>
> If I invoke some Jelly script within an xml tag this "body" will not be parsed
> correctly. As far as I understand the code the sequence
>             handler.startDocument();
>             invokeBody( newOutput);
>             handler.endDocument();
> will always create an empty document since no tag will ever be reported and thus
> all writes will be ignored.
> The whole code in the body of the parseBody method in ParseTagSupport.java
> should be replaced by
>     protected Document parseBody(XMLOutput output) throws JellyTagException {
>         return parseText(getBodyText(false));
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

Posted by "Hans Gilde (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57808 ]
     
Hans Gilde commented on JELLY-188:
----------------------------------

Wait, are you saying that the parse tag doesn't work when applied to the body?

> tag library xml does not correctly parse body
> ---------------------------------------------
>
>          Key: JELLY-188
>          URL: http://issues.apache.org/jira/browse/JELLY-188
>      Project: jelly
>         Type: Bug
>   Components: taglib.xml
>     Reporter: dion gillard

>
> If I invoke some Jelly script within an xml tag this "body" will not be parsed
> correctly. As far as I understand the code the sequence
>             handler.startDocument();
>             invokeBody( newOutput);
>             handler.endDocument();
> will always create an empty document since no tag will ever be reported and thus
> all writes will be ignored.
> The whole code in the body of the parseBody method in ParseTagSupport.java
> should be replaced by
>     protected Document parseBody(XMLOutput output) throws JellyTagException {
>         return parseText(getBodyText(false));
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org