[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2694: GOBBLIN-836: Expose container logs location via system property to be…

[GitBox <gi...@apache.org>]

sv2000 opened a new pull request #2694: GOBBLIN-836: Expose container logs location via system property to be…
URL: https://github.com/apache/incubator-gobblin/pull/2694
 
 
   … used in log4j configuration for Gobblin-on-Yarn applications
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-836
   Expose container logs location via system property to be used in log4j configuration for Gobblin-on-Yarn applications
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   This task exposes container log directory and container log file name via Java System properties, so that they can be referenced in log4j properties. This in turn allows configuring log rotation of container logs based on size and maximum number of back ups.
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Tested by deploying a Gobblin-on-Yarn application
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services