[GitHub] chetanmeh commented on a change in pull request #3747: Memory based loadbalancing

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #3747: Memory based loadbalancing
URL: https://github.com/apache/incubator-openwhisk/pull/3747#discussion_r213647966
 
 

 ##########
 File path: core/controller/src/main/resources/reference.conf
 ##########
 @@ -6,7 +6,7 @@ whisk {
     use-cluster-bootstrap: false
   }
   loadbalancer {
-    invoker-busy-threshold: 4
+    user-memory: 1024 m
 
 Review comment:
   @cbickel Should this be named `invoker-user-memory`. I see following exception on startup as in my case `CONFIG_whisk_loadbalancer_invokerUserMemory` was not defined
   
   ```
   Exception in thread "main" pureconfig.error.ConfigReaderException: Cannot convert configuration to a whisk.core.loadBalancer.ShardingContainerPoolBalancerConfig. Failures are:
     at 'whisk.loadbalancer':
       - Key not found: 'invoker-user-memory'.
   
   	at pureconfig.package$.getResultOrThrow(package.scala:138)
   	at pureconfig.package$.loadConfigOrThrow(package.scala:160)
   	at whisk.core.loadBalancer.ShardingContainerPoolBalancer.<init>(ShardingContainerPoolBalancer.scala:159)
   	at whisk.core.loadBalancer.ShardingContainerPoolBalancer$.instance(ShardingContainerPoolBalancer.scala:437)
   	at whisk.core.controller.Controller.<init>(Controller.scala:117)
   	at whisk.core.controller.Controller$.main(Controller.scala:258)
   	at whisk.core.controller.Controller.main(Controller.scala)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services