You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/17 02:24:05 UTC

[GitHub] [spark] rangadi opened a new pull request, #38680: [SPARK-40657][FOLLOWUP]Minor: Add clarifying comment in ProtobufUtils

rangadi opened a new pull request, #38680:
URL: https://github.com/apache/spark/pull/38680

   ### What changes were proposed in this pull request?
   This is a follow up to address couple of comments in #38384.
   Fixes a comment and adds explanation about why we don't use "com.google.protobuf.Message" directly in a string. 
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Existing unit tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] rangadi commented on pull request #38680: [SPARK-40657][FOLLOWUP]Minor: Add clarifying comment in ProtobufUtils

Posted by GitBox <gi...@apache.org>.
rangadi commented on PR #38680:
URL: https://github.com/apache/spark/pull/38680#issuecomment-1317967322

   @HeartSaVioR PTAL. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR closed pull request #38680: [SPARK-40657][PROTOBUF][FOLLOWUP][MINOR] Add clarifying comment in ProtobufUtils

Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #38680: [SPARK-40657][PROTOBUF][FOLLOWUP][MINOR] Add clarifying comment in ProtobufUtils
URL: https://github.com/apache/spark/pull/38680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #38680: [SPARK-40657][PROTOBUF][FOLLOWUP][MINOR] Add clarifying comment in ProtobufUtils

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #38680:
URL: https://github.com/apache/spark/pull/38680#issuecomment-1319400995

   https://github.com/rangadi/spark/actions/runs/3490416069/jobs/5847475694
   Second trial of build is passing for most of jobs and pending k8s integration which I don't believe this PR will break it.
   
   Thanks! Merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org