You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Bill Stoddard <bi...@wstoddard.com> on 2001/04/10 16:18:19 UTC
Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c
What is this change about?
> --- mpm_common.c 2001/03/19 13:07:26 1.44
> +++ mpm_common.c 2001/04/06 20:12:05 1.45
> @@ -126,9 +126,9 @@
> switch (tries) {
> case 1: /* 16ms */
> case 2: /* 82ms */
> - break;
> case 3: /* 344ms */
> case 4: /* 16ms */
> + break;
> case 5: /* 82ms */
> case 6: /* 344ms */
> case 7: /* 1.4sec */
>
Bill
Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c
Posted by "Paul J. Reder" <re...@raleigh.ibm.com>.
Bill Stoddard wrote:
>
> What is this change about?
>
> > --- mpm_common.c 2001/03/19 13:07:26 1.44
> > +++ mpm_common.c 2001/04/06 20:12:05 1.45
> > @@ -126,9 +126,9 @@
> > switch (tries) {
> > case 1: /* 16ms */
> > case 2: /* 82ms */
> > - break;
> > case 3: /* 344ms */
> > case 4: /* 16ms */
> > + break;
> > case 5: /* 82ms */
> > case 6: /* 344ms */
> > case 7: /* 1.4sec */
> >
>
> Bill
Because the idle cleanup no longer happens immediately based on a signal but is
now delayed based on a flag. Some of the kids were taking slightly longer to go
away and were triggering the annoying logs and additional kills that resulted
from this code. By moving it slightly the kids had time to go away naturally.
To be honest though, this was put in with the first patch. After the optimizations
suggested by Greg Ames I am not entirely sure this is still needed (I forgot to
test without it), but I suspect it is still needed because the delay comes not from
the checking overhead but from the delay while the child finishes its work before
checking the flag again.
--
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it. Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein