You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "stats-dev (via GitHub)" <gi...@apache.org> on 2026/03/08 12:31:02 UTC

[PR] Improve Playwright test patterns in `backfill.spec.ts` [airflow]

stats-dev opened a new pull request, #63112:
URL: https://github.com/apache/airflow/pull/63112

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   
   
   Refactor `backfill.spec.ts` and `BackfillPage.ts` to align with Playwright best practices.
   * Replace `page.waitForTimeout()` with `expect.poll()`
   * Replace manual assertions with web-first `toHaveCount()` assertions
   * Replace CSS :`has-text()` with `getByText()` user-facing locator
   * Remove unused `getTableColumnCount()` method
   
   closes: #63041
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [x] Yes (Antigravity)
   
   
   Generated-by: Antigravity following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve Playwright test patterns in `backfill.spec.ts` [airflow]

Posted by "stats-dev (via GitHub)" <gi...@apache.org>.
stats-dev commented on PR #63112:
URL: https://github.com/apache/airflow/pull/63112#issuecomment-4020752033

   > Cool, LGTM :)
   
   Thanks for your guidance and helpful feedback! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve Playwright test patterns in `backfill.spec.ts` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 merged PR #63112:
URL: https://github.com/apache/airflow/pull/63112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org