[GitHub] [accumulo] keith-turner commented on a diff in pull request #3601: syncs ZK before reading root tablet metadata

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3601:
URL: https://github.com/apache/accumulo/pull/3601#discussion_r1265783695


##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -537,7 +537,11 @@ private static TabletMetadata getRootMetadata(ClientContext ctx,
       case IMMEDIATE:
         ZooReader zooReader = ctx.getZooReader();
         try {
-          byte[] bytes = zooReader.getData(zkRoot + RootTable.ZROOT_TABLET);
+          var path = zkRoot + RootTable.ZROOT_TABLET;

Review Comment:
   I think the evenutal  case was for code that used to use zoocache to read root tablet metadata that was adpated to use Ample.  That code did not care if it got the latest and greatest, it just wanted performance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org