You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/04/15 14:19:34 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1088: Fix #1087, wrap FileWriter with BufferedWriter

ctubbsii commented on a change in pull request #1088: Fix #1087, wrap FileWriter with BufferedWriter
URL: https://github.com/apache/accumulo/pull/1088#discussion_r275380804
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##########
 @@ -506,7 +507,7 @@ private void printNameSpaceConfiguration(AccumuloClient accumuloClient, String n
       File outputDirectory)
       throws IOException, AccumuloException, AccumuloSecurityException, NamespaceNotFoundException {
     File namespaceScript = new File(outputDirectory, namespace + NS_FILE_SUFFIX);
-    FileWriter nsWriter = new FileWriter(namespaceScript);
+    BufferedWriter nsWriter = new BufferedWriter(new FileWriter(namespaceScript));
 
 Review comment:
   This should be done in a try-with-resources block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services