You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ma...@apache.org on 2023/10/25 07:38:27 UTC

[flink] branch release-1.18 updated: [FLINK-33346][runtime][test] Removes timeout

This is an automated email from the ASF dual-hosted git repository.

mapohl pushed a commit to branch release-1.18
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.18 by this push:
     new 8be1c870e39 [FLINK-33346][runtime][test] Removes timeout
8be1c870e39 is described below

commit 8be1c870e395225d9aa236a7349444e8f8340459
Author: Matthias Pohl <ma...@aiven.io>
AuthorDate: Tue Oct 24 09:55:43 2023 +0200

    [FLINK-33346][runtime][test] Removes timeout
    
    The instability is caused by the timeout. The fatal error hides the actual cause (i.e. the TimeoutException). It can be reproduced by setting the timeout of the test to 0ms. The actual cause is revealed when disabling the fatal error handling or not throwing a AssertionError in case of the fatal error.
---
 .../flink/runtime/dispatcher/DispatcherResourceCleanupTest.java       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
index 13fb6afac04..1be9135acea 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
@@ -568,9 +568,7 @@ public class DispatcherResourceCleanupTest extends TestLogger {
 
         final CompletableFuture<? extends Throwable> errorFuture =
                 this.testingFatalErrorHandlerResource.getFatalErrorHandler().getErrorFuture();
-        assertThat(
-                errorFuture.get(100, TimeUnit.MILLISECONDS),
-                IsInstanceOf.instanceOf(FlinkException.class));
+        assertThat(errorFuture.get(), IsInstanceOf.instanceOf(FlinkException.class));
         testingFatalErrorHandlerResource.getFatalErrorHandler().clearError();
     }