You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/12/14 00:23:47 UTC

[GitHub] [ozone] swagle commented on a change in pull request #2913: HDDS-6098. Add a metric to track amount of data committed.

swagle commented on a change in pull request #2913:
URL: https://github.com/apache/ozone/pull/2913#discussion_r768223794



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -339,6 +339,7 @@ protected void processResult(CommitKeyRequest commitKeyRequest,
       // versioning of keys. So, this can be revisited later.
       if (omKeyInfo.getKeyLocationVersions().size() == 1) {
         omMetrics.incNumKeys();
+        omMetrics.incDataCommittedBytes(omKeyInfo.getDataSize());

Review comment:
       I think this will not survive restarts! @avijayanhwx?
   Possibly might need to read it back from store if this is meant to be cumulative value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org