You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/07 11:17:17 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5051: [HUDI-3643] Fix hive count exception when the table is empty and the path depth is less than 3

xushiyan commented on code in PR #5051:
URL: https://github.com/apache/hudi/pull/5051#discussion_r845013508


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java:
##########
@@ -324,14 +326,24 @@ public static HoodieTimeline getHoodieTimelineForIncrementalQuery(JobContext job
    * Extract HoodieTableMetaClient from a partition path (not base path)
    */
   public static HoodieTableMetaClient getTableMetaClientForBasePathUnchecked(Configuration conf, Path partitionPath) throws IOException {

Review Comment:
   can we add a specific UT for this method alone? to cover different logic branches in the method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org