[GitHub] [logging-log4j2] david-burke-securian commented on a change in pull request #601: LOG4J2-3193 Configuration precedence fix

[GitBox <gi...@apache.org>]

david-burke-securian commented on a change in pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#discussion_r758490618



##########
File path: log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
##########
@@ -81,16 +81,22 @@ default boolean containsProperty(String key) {
     }
 
     /**
-     * Comparator for ordering PropertySource instances by priority.
-     *
-     * @since 2.10.0
-     */
+	 * Comparator for ordering PropertySource instances by priority.
+	 * Specifically, this Comparator will sort by Priority (int) in
+	 * <i>reverse</i> numerical order because a source with priority -100 has a
+	 * <i>higher</i> priority (can override values from) a source with priority
+	 * 100.
+	 *
+	 * @since 2.10.0
+	 */

Review comment:
       oops! I fixed that once but I must have gone back and changed something and forgot to disable format-on-save. I noticed some imports got unnecessarily changed too. Should be all fixed now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org