You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2008/07/22 15:05:50 UTC
Re: svn commit: r32186 - branches/1.5.x
hwright@tigris.org wrote on Fri, 18 Jul 2008 at 12:33 -0700:
> Author: hwright
> Date: Fri Jul 18 12:33:38 2008
> New Revision: 32186
>
> Log:
> * STATUS: Add some votes.
>
> Note: r32185 is a comment typo fix in an obvious fix-ish sort of way, so
> it does not require granular votes.
>
> Modified:
> branches/1.5.x/STATUS
>
> Modified: branches/1.5.x/STATUS
> URL: http://svn.collab.net/viewvc/svn/branches/1.5.x/STATUS?pathrev=32186&r1=32185&r2=32186
> ==============================================================================
> --- branches/1.5.x/STATUS Fri Jul 18 12:31:10 2008 (r32185)
> +++ branches/1.5.x/STATUS Fri Jul 18 12:33:38 2008 (r32186)
> @@ -126,7 +126,7 @@ Candidate changes for 1.5.1:
> +1: pburba
>
>
> - * r32153, r32160
> + * r32153, r32160, r32185
> Fix issues #3220 (log -g is slow) and #3235 (log -g is wrong).
> Justification:
> Slowness is bad -- in some tests, this fix decreased the cost of a log -g
r32185 has been reverted on trunk, should it still be nominated?
$ svn log -r 32185
------------------------------------------------------------------------
r32185 | hwright | 2008-07-18 22:31:10 +0300 (Fri, 18 Jul 2008) | 5 lines
*** This commit was reverted in r32206 ***
* subversion/libsvn_repos/log.c
(svn_repos_mergeinfo_changed): Fix typos in comment.
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32186 - branches/1.5.x
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Hyrum K. Wright wrote on Tue, 22 Jul 2008 at 10:17 -0500:
> It looks as if the edit to r32185 was meant for r32158 instead. So let's
> keep r32185. :)
Okay. :) I've fixed the log messages.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32186 - branches/1.5.x
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
C. Michael Pilato wrote:
> Daniel Shahaf wrote:
>> hwright@tigris.org wrote on Fri, 18 Jul 2008 at 12:33 -0700:
>>> Author: hwright
>>> Date: Fri Jul 18 12:33:38 2008
>>> New Revision: 32186
>>>
>>> Log:
>>> * STATUS: Add some votes.
>>>
>>> Note: r32185 is a comment typo fix in an obvious fix-ish sort of way, so
>>> it does not require granular votes.
>
> I can't recall the details, but the typo might need to be applied to a
> different location.
The typo doesn't appear on trunk, and it looks like r32185 *wasn't* reverted:
w-mob400-128-62-215-35:libsvn_repos Hyrum$ svn blame log.c | grep before
32153 cmpilato revision before assuming it holds the same path it
did the
32185 hwright before and after mergeinfo values in our return
hashes. */
14759 djh to hold on to the old pool with the history before we can
25314 hwright /* Check that revisions are sane before ever invoking
receiver. */
However, r31258 was reverted in r32206:
hyrum-wrights-macbook-pro:svn-trunk Hyrum$ svn log -r32206
------------------------------------------------------------------------
r32206 | cmpilato | 2008-07-21 13:28:25 -0500 (Mon, 21 Jul 2008) | 10 lines
Revert r32158, which apparently was premature in a number of ways.
...
It looks as if the edit to r32185 was meant for r32158 instead. So let's keep
r32185. :)
-Hyrum
Re: svn commit: r32186 - branches/1.5.x
Posted by "C. Michael Pilato" <cm...@collab.net>.
Daniel Shahaf wrote:
> hwright@tigris.org wrote on Fri, 18 Jul 2008 at 12:33 -0700:
>> Author: hwright
>> Date: Fri Jul 18 12:33:38 2008
>> New Revision: 32186
>>
>> Log:
>> * STATUS: Add some votes.
>>
>> Note: r32185 is a comment typo fix in an obvious fix-ish sort of way, so
>> it does not require granular votes.
I can't recall the details, but the typo might need to be applied to a
different location.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand