[GitHub] [incubator-doris] yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load

[GitBox <gi...@apache.org>]

yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load
URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-518150837
 
 
   > @yuanlihan
   > 
   > I prefer first option. However I think there should be some change in your version.
   > 
   > 1. we can still use `INFILE`. We support path has wildcard. for load directory, user can specify the path like "base_dir/*". This is also consistent with the previous usage.
   > 2. I think we should keep numbers of our keywords as small as possible. So PARTITIONED_COLUMNS and BASE_DIR should be reconsidered. For example `PARTITION COLUMNS` or `BASE DIR`?
   > 3. PARTITIONED_COLUMNS has no relation with PARTITION. This may confuse our users. Can we have better choice?
   
   @imay 
   1. Currently the path with wildcard only list files under the directory, but we need to list files recursively. Can we change the logic of wildcard-path(eg, "base_dir/*") to recursively listing files?
   2. What about change _[BASE_PATH AS "base_path"]_ as **_[PATH START WITH "base_path"]_** and change _[PARTITIONED_COLUMNS AS (partitioned_column_list)]_ as **_[COLUMNS FROM PATH AS (columns_from_path)]_**? Then we only need to add a key word PATH.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org