You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/01/04 01:30:54 UTC
Review Request 64939: Abort libprocess when a Process throws an
uncaught exception.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64939/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ilya Pronin, Jie Yu, and Jiang Yan Xu.
Repository: mesos
Description
-------
Previously, we logged the exception, terminated the throwing
Process, and continued to run. However, currently there exists
no known user-level code that I'm aware of that handles the
unexpected termination due to an uncaught exception.
Generally, this means that when an exception is thrown (e.g.
a bad call to std::map::at), the process terminates with a log
message but things get "stuck" and the user has to debug what
is wrong / kill the process.
Libprocess would likely need to provide some primitives to
better support handling unexpected termination of a Process
in order for us to provide a strategy where we continue running.
Diffs
-----
3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
Diff: https://reviews.apache.org/r/64939/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 64939: Abort libprocess when a Process throws an
uncaught exception.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64939/#review194824
-----------------------------------------------------------
PASS: Mesos patch 64939 was successfully built and tested.
Reviews applied: `['64939']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64939
- Mesos Reviewbot Windows
On Jan. 4, 2018, 1:30 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64939/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 1:30 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ilya Pronin, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we logged the exception, terminated the throwing
> Process, and continued to run. However, currently there exists
> no known user-level code that I'm aware of that handles the
> unexpected termination due to an uncaught exception.
>
> Generally, this means that when an exception is thrown (e.g.
> a bad call to std::map::at), the process terminates with a log
> message but things get "stuck" and the user has to debug what
> is wrong / kill the process.
>
> Libprocess would likely need to provide some primitives to
> better support handling unexpected termination of a Process
> in order for us to provide a strategy where we continue running.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
>
>
> Diff: https://reviews.apache.org/r/64939/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 64939: Abort libprocess when a Process throws an
uncaught exception.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64939/#review194733
-----------------------------------------------------------
Ship it!
Ship It!
- Ilya Pronin
On Jan. 3, 2018, 5:30 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64939/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2018, 5:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ilya Pronin, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we logged the exception, terminated the throwing
> Process, and continued to run. However, currently there exists
> no known user-level code that I'm aware of that handles the
> unexpected termination due to an uncaught exception.
>
> Generally, this means that when an exception is thrown (e.g.
> a bad call to std::map::at), the process terminates with a log
> message but things get "stuck" and the user has to debug what
> is wrong / kill the process.
>
> Libprocess would likely need to provide some primitives to
> better support handling unexpected termination of a Process
> in order for us to provide a strategy where we continue running.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
>
>
> Diff: https://reviews.apache.org/r/64939/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 64939: Abort libprocess when a Process throws an
uncaught exception.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64939/#review194774
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Jan. 3, 2018, 5:30 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64939/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2018, 5:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ilya Pronin, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we logged the exception, terminated the throwing
> Process, and continued to run. However, currently there exists
> no known user-level code that I'm aware of that handles the
> unexpected termination due to an uncaught exception.
>
> Generally, this means that when an exception is thrown (e.g.
> a bad call to std::map::at), the process terminates with a log
> message but things get "stuck" and the user has to debug what
> is wrong / kill the process.
>
> Libprocess would likely need to provide some primitives to
> better support handling unexpected termination of a Process
> in order for us to provide a strategy where we continue running.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
>
>
> Diff: https://reviews.apache.org/r/64939/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>