You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:19:05 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails in timer thread
JingsongLi commented on a change in pull request #18822:
URL: https://github.com/apache/flink/pull/18822#discussion_r810870801
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java
##########
@@ -154,7 +154,9 @@ public void open(int taskNumber, int numTasks) throws IOException {
try {
flush();
} catch (Exception e) {
- flushException = e;
+ if (flushException == null) {
Review comment:
What do you think about:
`flushException = ExceptionUtils.firstOrSuppressed(e, flushException);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org