[GitHub] [cordova-plugin-inappbrowser] AhrenFullStop opened a new pull request #551: Update InAppBrowser.java

[GitBox <gi...@apache.org>]

AhrenFullStop opened a new pull request #551: Update InAppBrowser.java
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/551
 
 
   in line with allowing custom URI schemes and this issue I've changed the if statement that enforces http for no apparent reason: https://github.com/apache/cordova-plugin-inappbrowser/issues/548
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   IOS and Android, allows custom URI Schemes
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   fixes issue here: https://github.com/apache/cordova-plugin-inappbrowser/issues/548
   Allows the user to use window.open() to open custom URI's such as intents (tel:// or anotherapp://) easily.
   
   ### Description
   <!-- Describe your changes in detail -->
   All I did was remove an if statement that checks for the URI starting with Http, Https or File. so that the uri can be in any format.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tested locally, working.
   
   
   ### Checklist
   
   - [ x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change - no, tiny change
   - [ x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org