You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/13 21:11:01 UTC
svn commit: r1022244 -
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
Author: sebb
Date: Wed Oct 13 19:11:01 2010
New Revision: 1022244
URL: http://svn.apache.org/viewvc?rev=1022244&view=rev
Log:
Make private immutable fields final
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java?rev=1022244&r1=1022243&r2=1022244&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java Wed Oct 13 19:11:01 2010
@@ -2504,7 +2504,7 @@ public class GenericKeyedObjectPool<K,V>
private long _minEvictableIdleTimeMillis = DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS;
/** My hash of pools (ObjectQueue). */
- private Map<K,ObjectQueue> _poolMap = null;
+ private final Map<K,ObjectQueue> _poolMap;
/** The total number of active instances. */
private int _totalActive = 0;
@@ -2531,7 +2531,7 @@ public class GenericKeyedObjectPool<K,V>
* A cursorable list of my pools.
* @see GenericKeyedObjectPool.Evictor#run
*/
- private CursorableLinkedList<K> _poolList = null;
+ private final CursorableLinkedList<K> _poolList;
/** Eviction cursor (over instances within-key) */
private CursorableLinkedList<ObjectTimestampPair<V>>.Cursor _evictionCursor = null;
@@ -2547,6 +2547,6 @@ public class GenericKeyedObjectPool<K,V>
* that objects can be allocated in the order in which the threads requested
* them.
*/
- private LinkedList<Latch> _allocationQueue = new LinkedList<Latch>();
+ private final LinkedList<Latch> _allocationQueue = new LinkedList<Latch>();
}