You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/28 15:48:41 UTC
[GitHub] [trafficserver] bneradt commented on a change in pull request #7218: Stop crash on disk failure
bneradt commented on a change in pull request #7218:
URL: https://github.com/apache/trafficserver/pull/7218#discussion_r496053596
##########
File path: iocore/cache/Cache.cc
##########
@@ -590,12 +590,25 @@ CacheProcessor::start_internal(int flags)
check = (flags & PROCESSOR_CHECK) != 0;
start_done = 0;
Span *sd;
+ char **paths;
+ int *fds;
+ int *sector_sizes;
Review comment:
I suggest we move the sd declaration down to it's use in the for loop, and move the rest of these declarations to their initialization a few lines below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org