You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David Hay (JIRA)" <ji...@apache.org> on 2006/10/20 17:20:38 UTC
[jira] Created: (PLUTO-261) PortalServletRequest makes a redundant
check
PortalServletRequest makes a redundant check
--------------------------------------------
Key: PLUTO-261
URL: http://issues.apache.org/jira/browse/PLUTO-261
Project: Pluto
Issue Type: Bug
Components: portal driver
Affects Versions: 1.1.0-beta2
Reporter: David Hay
On lines 95-96 of PortalServletRequest, the following code exists:
String id = portletWindow.getId().getStringId();
if (portletWindow.getId().getStringId().equals(id)) {
This will always evaluate to true. What I suspect was intended here was the following:
String id = portletWindow.getId().getStringId();
if (url.getActionWindow().equals(id)) {
So that the query parameters were only included in the request for the portlet processing an action.
BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Created: (PLUTO-261) PortalServletRequest makes a redundant
check
Posted by "David H. DeWolf" <dd...@apache.org>.
Thanks!
1.1.0-beta2 is now marked as released.
David
David Hay (JIRA) wrote:
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
>
>
> On lines 95-96 of PortalServletRequest, the following code exists:
>
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
>
> This will always evaluate to true. What I suspect was intended here was the following:
>
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
>
> So that the query parameters were only included in the request for the portlet processing an action.
>
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
>
[jira] Commented: (PLUTO-261) PortalServletRequest makes a
redundant check
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-261?page=comments#action_12455838 ]
David DeWolf commented on PLUTO-261:
------------------------------------
I agree that this is some lousy logic, but I'm not convinced that is should be checking for the actionId. The PortalServletRequest is only used for rendering...actions should not come into play here and the parameters recieved from the url will all be render parameters.
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
> Assigned To: David DeWolf
> Fix For: 1.1.0
>
>
> On lines 95-96 of PortalServletRequest, the following code exists:
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
> This will always evaluate to true. What I suspect was intended here was the following:
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
> So that the query parameters were only included in the request for the portlet processing an action.
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PLUTO-261) PortalServletRequest makes a redundant
check
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-261?page=all ]
David DeWolf updated PLUTO-261:
-------------------------------
Fix Version/s: 1.1.0
Assignee: David DeWolf
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
> Assigned To: David DeWolf
> Fix For: 1.1.0
>
>
> On lines 95-96 of PortalServletRequest, the following code exists:
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
> This will always evaluate to true. What I suspect was intended here was the following:
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
> So that the query parameters were only included in the request for the portlet processing an action.
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (PLUTO-261) PortalServletRequest makes a redundant
check
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-261?page=all ]
David DeWolf resolved PLUTO-261.
--------------------------------
Resolution: Fixed
Resolved. I think you're right that was the original intent, so I went ahead and made that the change. It will never get called, and I documented it as such. I left it in b/c some day we could use it for actions.
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
> Assigned To: David DeWolf
> Fix For: 1.1.0
>
>
> On lines 95-96 of PortalServletRequest, the following code exists:
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
> This will always evaluate to true. What I suspect was intended here was the following:
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
> So that the query parameters were only included in the request for the portlet processing an action.
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PLUTO-261) PortalServletRequest makes a
redundant check
Posted by "David Hay (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-261?page=comments#action_12443874 ]
David Hay commented on PLUTO-261:
---------------------------------
Acutally, the if condition should be reversed in case the actionWindow is null
id.equals(url.getActionWindow())
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
>
> On lines 95-96 of PortalServletRequest, the following code exists:
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
> This will always evaluate to true. What I suspect was intended here was the following:
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
> So that the query parameters were only included in the request for the portlet processing an action.
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira