[GitHub] [maven-dependency-plugin] van-vliet commented on a change in pull request #133: [MDEP-739] Dependency Plugin go-offline doesn't respect artifact classifier

[GitBox <gi...@apache.org>]

van-vliet commented on a change in pull request #133:
URL: https://github.com/apache/maven-dependency-plugin/pull/133#discussion_r640303683



##########
File path: src/it/projects/mdep-739-go-offline-respect-classifiers/invoker.properties
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.java.version = 1.9+

Review comment:
       MDEP-739 is not caused by a specific Java version, so any version should work. 
   I just tried removing this line from the code and the test still passes.
   
   This line is here because I copied one of the other integration tests. I tried creating a test for the go-offline mojo using AbstractMojoTestCase included in org.apache.maven.plugin-testing:maven-plugin-testing-harness:3.1.0, but I ran into issues with fields that the testing harness did not set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org