You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by rkarthik29 <gi...@git.apache.org> on 2016/12/22 16:29:18 UTC
[GitHub] nifi pull request #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Sta...
GitHub user rkarthik29 opened a pull request:
https://github.com/apache/nifi/pull/1355
NIFI-1856 ExecuteStreamCommand Needs to Consume Standard Error
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rkarthik29/nifi-1 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1355
----
commit 862292f7ccba3448831a17b363fe88ab5872aca0
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-11-21T01:18:45Z
NiFI-3604 onvert to Avro fails when a MySQL query returns two columns with the same name even with different aliases
commit d8d598b3472d709349eb3d25f8d10cbad8be556b
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-11-30T20:29:32Z
Merge branch 'master' of https://github.com/apache/nifi
commit 417f944173c9d155f8f38b9f803a58eaaca5518d
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-12-12T14:47:09Z
Merge branch 'master' of https://github.com/apache/nifi
commit b7bf487ba743eb9a6664d06b399e2712eeba05fd
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-12-19T19:11:31Z
Merge branch 'master' of https://github.com/apache/nifi
commit 384325fe6a1965d435ced0ec1afb75a6ef9a0bd6
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-12-22T05:30:26Z
Nifi-1856 ExecuteStreamCommand Needs to Consume Standard Error
commit 131869a8e22af78c366691e8944ef57c49bb53c6
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-12-22T16:04:44Z
Merge branch 'master' of https://github.com/apache/nifi
commit 27fb13e4d274ba83ce0873457f103bb0f4d54316
Author: Kathik Narayanan <kn...@hortonworks.com>
Date: 2016-12-22T16:05:26Z
Merge branch 'nifi-1856'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Standard E...
Posted by rkarthik29 <gi...@git.apache.org>.
Github user rkarthik29 commented on the issue:
https://github.com/apache/nifi/pull/1355
added a property to executeSTreamCommand "Redirect Error Output". [log,output stream, error stream]. log is the default.
When set to log, the error stream is captured and output is logged to the Nifi app logs at the warn level.Also, the errors are available in the original stream as an attribute, which is the current behavior.
When set to output stream, the redirecterrorstream is set to true so all errors go to the output streams and are available in the output stream relation
when set to error stream, the error output is forwarded to an errorflowfile which is available in the error stream relationship.The error stream relationship is new.
Added a process.destroyforcibly of the processor unscheduled event.
Checked execute process, it was already capturing the error stream, so no change needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Standard E...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1355
Many of the commits are merge commits, when this PR is merged it can make the commit log fairly messy. Do you mind rebasing your own branch against the latest "upstream" master branch. You may find it helpful to create a branch specifically for this PR, then reset your own master branch to upstream, then you can rebase this branch against master without worrying whether to fetch or pull from upstream in the future. Not a requirement, just a suggestion to help keep things a bit cleaner :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Sta...
Posted by jackowaya <gi...@git.apache.org>.
Github user jackowaya commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1355#discussion_r93767588
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java ---
@@ -186,7 +195,15 @@ public ValidationResult validate(String subject, String input, ValidationContext
.addValidator(StandardValidators.createDirectoryExistsValidator(true, true))
.required(false)
.build();
-
+ static final PropertyDescriptor REDIRECT_ERROR = new PropertyDescriptor.Builder()
+ .name("Redirect Error Stream")
+ .description("where shoud the error stream from external process get redirected"
+ + "\n1) log - outputs to the nifi logger"
+ + "\n2) output stream - redirects to the output stream relation"
+ + "\n3) error stream - redirects to the error stream relation")
+ .allowableValues("log", "output stream","error stream")
--- End diff --
It would be better to hold these strings in static final variables so they can be reused later without fear of mistyping.
Also spacing looks off here. You should run autoformat again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Sta...
Posted by jackowaya <gi...@git.apache.org>.
Github user jackowaya commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1355#discussion_r93697662
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java ---
@@ -16,6 +16,25 @@
*/
package org.apache.nifi.processors.standard;
+import java.io.BufferedReader;
--- End diff --
I'm not sure if nifi has an import order rule, but generally I try to avoid commits that move a lot of imports around like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Sta...
Posted by rkarthik29 <gi...@git.apache.org>.
Github user rkarthik29 closed the pull request at:
https://github.com/apache/nifi/pull/1355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1355: NIFI-1856 ExecuteStreamCommand Needs to Consume Standard E...
Posted by rkarthik29 <gi...@git.apache.org>.
Github user rkarthik29 commented on the issue:
https://github.com/apache/nifi/pull/1355
I did a contrib check and there were no style errors. I agree using final variables would be nicer , will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---