You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Thomas Leonard (JIRA)" <ji...@apache.org> on 2007/08/09 12:07:42 UTC
[jira] Created: (AXIS2-3108) Broken WSDL for operations added by
modules
Broken WSDL for operations added by modules
-------------------------------------------
Key: AXIS2-3108
URL: https://issues.apache.org/jira/browse/AXIS2-3108
Project: Axis 2.0 (Axis2)
Issue Type: Bug
Components: kernel
Affects Versions: 1.2
Reporter: Thomas Leonard
Fix For: 1.3
Using Axis2 1.3-RC2, we get WSDL that looks like this:
<wsdl:message name=""/>
<wsdl:message name="sayHelloRequest">
<wsdl:part name="parameters" element="ns0:sayHello"/>
</wsdl:message>
<wsdl:message name="sayHelloResponse">
<wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
</wsdl:message>
<wsdl:message name="XMLStreamException">
<wsdl:part name="parameters" element="ns0:XMLStreamException"/>
</wsdl:message>
<wsdl:message name="pingRequest"/>
<wsdl:message name="pingResponse"/>
<wsdl:portType name="SampleServicePortType">
<wsdl:operation name="getServiceProviderID">
<wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
<wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
</wsdl:operation>
<wsdl:operation name="sayHello">
<wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
<wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
<wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
</wsdl:operation>
<wsdl:operation name="ping">
<wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
<wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
</wsdl:operation>
</wsdl:portType>
This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
<wsdl:message name=""/>
...
<wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
<wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-3108) Broken WSDL for operations added by
modules
Posted by "Thomas Leonard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Leonard updated AXIS2-3108:
----------------------------------
Attachment: module-ops.patch
The attached patch fixes the problem for me. However, the code should be refactored to avoid duplication.
> Broken WSDL for operations added by modules
> -------------------------------------------
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2
> Reporter: Thomas Leonard
> Fix For: nightly
>
> Attachments: module-ops.patch
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> <wsdl:message name=""/>
> <wsdl:message name="sayHelloRequest">
> <wsdl:part name="parameters" element="ns0:sayHello"/>
> </wsdl:message>
> <wsdl:message name="sayHelloResponse">
> <wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
> </wsdl:message>
> <wsdl:message name="XMLStreamException">
> <wsdl:part name="parameters" element="ns0:XMLStreamException"/>
> </wsdl:message>
> <wsdl:message name="pingRequest"/>
> <wsdl:message name="pingResponse"/>
> <wsdl:portType name="SampleServicePortType">
> <wsdl:operation name="getServiceProviderID">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
> </wsdl:operation>
> <wsdl:operation name="sayHello">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
> <wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
> </wsdl:operation>
> <wsdl:operation name="ping">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> </wsdl:operation>
> </wsdl:portType>
> This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
> <wsdl:message name=""/>
> ...
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by
modules
Posted by "Thomas Leonard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611127#action_12611127 ]
Thomas Leonard commented on AXIS2-3108:
---------------------------------------
I can't see how to do that in JIRA. You're welcome to it, though.
> Broken WSDL for operations added by modules
> -------------------------------------------
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2
> Reporter: Thomas Leonard
> Attachments: module-ops.patch
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> <wsdl:message name=""/>
> <wsdl:message name="sayHelloRequest">
> <wsdl:part name="parameters" element="ns0:sayHello"/>
> </wsdl:message>
> <wsdl:message name="sayHelloResponse">
> <wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
> </wsdl:message>
> <wsdl:message name="XMLStreamException">
> <wsdl:part name="parameters" element="ns0:XMLStreamException"/>
> </wsdl:message>
> <wsdl:message name="pingRequest"/>
> <wsdl:message name="pingResponse"/>
> <wsdl:portType name="SampleServicePortType">
> <wsdl:operation name="getServiceProviderID">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
> </wsdl:operation>
> <wsdl:operation name="sayHello">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
> <wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
> </wsdl:operation>
> <wsdl:operation name="ping">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> </wsdl:operation>
> </wsdl:portType>
> This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
> <wsdl:message name=""/>
> ...
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by
modules
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611042#action_12611042 ]
Deepal Jayasinghe commented on AXIS2-3108:
------------------------------------------
Could you please grant the patch license to Apache , then only I can look at that.
Thank you!
Deepal
> Broken WSDL for operations added by modules
> -------------------------------------------
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2
> Reporter: Thomas Leonard
> Attachments: module-ops.patch
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> <wsdl:message name=""/>
> <wsdl:message name="sayHelloRequest">
> <wsdl:part name="parameters" element="ns0:sayHello"/>
> </wsdl:message>
> <wsdl:message name="sayHelloResponse">
> <wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
> </wsdl:message>
> <wsdl:message name="XMLStreamException">
> <wsdl:part name="parameters" element="ns0:XMLStreamException"/>
> </wsdl:message>
> <wsdl:message name="pingRequest"/>
> <wsdl:message name="pingResponse"/>
> <wsdl:portType name="SampleServicePortType">
> <wsdl:operation name="getServiceProviderID">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
> </wsdl:operation>
> <wsdl:operation name="sayHello">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
> <wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
> </wsdl:operation>
> <wsdl:operation name="ping">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> </wsdl:operation>
> </wsdl:portType>
> This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
> <wsdl:message name=""/>
> ...
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-3108) Broken WSDL for operations added by
modules
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe updated AXIS2-3108:
-------------------------------------
Fix Version/s: (was: 1.3)
nightly
> Broken WSDL for operations added by modules
> -------------------------------------------
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2
> Reporter: Thomas Leonard
> Fix For: nightly
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> <wsdl:message name=""/>
> <wsdl:message name="sayHelloRequest">
> <wsdl:part name="parameters" element="ns0:sayHello"/>
> </wsdl:message>
> <wsdl:message name="sayHelloResponse">
> <wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
> </wsdl:message>
> <wsdl:message name="XMLStreamException">
> <wsdl:part name="parameters" element="ns0:XMLStreamException"/>
> </wsdl:message>
> <wsdl:message name="pingRequest"/>
> <wsdl:message name="pingResponse"/>
> <wsdl:portType name="SampleServicePortType">
> <wsdl:operation name="getServiceProviderID">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
> </wsdl:operation>
> <wsdl:operation name="sayHello">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
> <wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
> </wsdl:operation>
> <wsdl:operation name="ping">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> </wsdl:operation>
> </wsdl:portType>
> This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
> <wsdl:message name=""/>
> ...
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by
modules
Posted by "Thomas Leonard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518679 ]
Thomas Leonard commented on AXIS2-3108:
---------------------------------------
There are two bugs causing this:
* ModuleBuilder.processOperations() doesn't set the message names, unlike ServiceBuilder.processOperations().
* AxisService.copyOperation() doesn't copy the message names.
By the way, there seems to be massive duplication of code here. ModuleBuilder.processOperations() was clearly copy-and-pasted from ServiceBuilder.processOperations(), but now they've diverged, each with its own bugs.
Likewise, AxisService.copyOperation() seems to be cut-and-pasted from AxisOperation.copyOperation(), which also contains the same bug.
> Broken WSDL for operations added by modules
> -------------------------------------------
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2
> Reporter: Thomas Leonard
> Fix For: 1.3
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> <wsdl:message name=""/>
> <wsdl:message name="sayHelloRequest">
> <wsdl:part name="parameters" element="ns0:sayHello"/>
> </wsdl:message>
> <wsdl:message name="sayHelloResponse">
> <wsdl:part name="parameters" element="ns0:sayHelloResponse"/>
> </wsdl:message>
> <wsdl:message name="XMLStreamException">
> <wsdl:part name="parameters" element="ns0:XMLStreamException"/>
> </wsdl:message>
> <wsdl:message name="pingRequest"/>
> <wsdl:message name="pingResponse"/>
> <wsdl:portType name="SampleServicePortType">
> <wsdl:operation name="getServiceProviderID">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
> </wsdl:operation>
> <wsdl:operation name="sayHello">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
> <wsdl:fault xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:XMLStreamException" name="XMLStreamException" wsaw:Action="urn:sayHelloXMLStreamException"/>
> </wsdl:operation>
> <wsdl:operation name="ping">
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingRequest" wsaw:Action="urn:ping"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> </wsdl:operation>
> </wsdl:portType>
> This is for the user guide's sample service, with a module adding the "getServiceProviderID" operation. Note that the messages have no name, even though the operation does:
> <wsdl:message name=""/>
> ...
> <wsdl:input xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderID"/>
> <wsdl:output xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" message="ns0:null" wsaw:Action="urn:getServiceProviderIDResponse"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org