You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/20 16:42:16 UTC
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
KishaniKandasamy opened a new pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [X] Bugfix
**Related issues**
fix: #1804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r617759315
##########
File path: docs/en/latest/FAQ.md
##########
@@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models
```shell
$ swagger-markdown -i ./docs/en/latest/api/api.yaml
```
+### 6. What is the default strategy when import a duplicate route?
Review comment:
may be for leaving a lineπ€?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r618032498
##########
File path: docs/en/latest/FAQ.md
##########
@@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models
```shell
$ swagger-markdown -i ./docs/en/latest/api/api.yaml
```
+### 6. What is the default strategy when import a duplicate route?
Review comment:
yep, only to fix the lint error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in in user guide
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* processing.
Building with commit a45ba91c9d0c446d8ad7dfc40435b8820e526019
https://app.netlify.com/sites/apisix-dashboard/deploys/6082994e17543c0008335746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* ready!
Built with commit a7d7b5b8a1ae8fb88b206d9aef601b11233aa443
https://deploy-preview-1808--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* processing.
Building with commit a7d7b5b8a1ae8fb88b206d9aef601b11233aa443
https://app.netlify.com/sites/apisix-dashboard/deploys/6080627e5d88f10008191d43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* ready!
Built with commit 61d7078c61539282868f1aaa310a8301777c467b
https://deploy-preview-1808--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in in user guide
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* ready!
Built with commit a45ba91c9d0c446d8ad7dfc40435b8820e526019
https://deploy-preview-1808--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r617289289
##########
File path: docs/en/latest/FAQ.md
##########
@@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models
```shell
$ swagger-markdown -i ./docs/en/latest/api/api.yaml
```
+### 6. What is the default strategy when import a duplicate route?
Review comment:
```suggestion
### 6. What is the default strategy when import a duplicate route?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r617583698
##########
File path: docs/en/latest/FAQ.md
##########
@@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models
```shell
$ swagger-markdown -i ./docs/en/latest/api/api.yaml
```
+### 6. What is the default strategy when import a duplicate route?
Review comment:

Seems no change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy closed pull request #1808: docs : FAQ in in user guide
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy closed pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
Deploy preview for *apisix-dashboard* processing.
Building with commit 08b678508fe86065c3c36f2aa3cdb4c942f76994
https://app.netlify.com/sites/apisix-dashboard/deploys/607f04605d14dc000787704d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r618050103
##########
File path: docs/en/latest/FAQ.md
##########
@@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models
```shell
$ swagger-markdown -i ./docs/en/latest/api/api.yaml
```
+### 6. What is the default strategy when import a duplicate route?
Review comment:
ππ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1808:
URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org